Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add canonical keyword for popover "auto" state #11302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

keithamus
Copy link
Contributor

@keithamus keithamus commented May 13, 2025

This fixes #11298 by adding a canonical keyword for the "auto" state. All engines exhibit this behaviour.

(See WHATWG Working Mode: Changes for more details.)


/popover.html ( diff )

@annevk
Copy link
Member

annevk commented May 13, 2025

This looks good and I'm happy to take this, but did you consider #11297 (comment) as an approach? Long term that seems better.

@keithamus
Copy link
Contributor Author

I did however it seems as though preload may need engine changes. I thought this would be helpful at least in the interim while #11297 is resolved.

@keithamus
Copy link
Contributor Author

This can be closed as #11297 & #11298 were both fixed by #11303

@keithamus keithamus closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

popover attribute does not define canonical keyword for auto state
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.