Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@beausmith
Copy link
Contributor

@beausmith beausmith commented Dec 14, 2016

Please note: two similar pull requests exist, both have errors:
#45 - still has copy-pasta: const hour = now.getMinutes()
#16 - typo hours should be hour

Update: Just realized that the index.html file is probably unnecessary given all the other projects use START and FINISHED files. Because of this and that the index.html file is nearly identical to the FINISHED file I have removed the index.html file.

@wesbos
Copy link
Owner

wesbos commented Dec 14, 2016

Thanks!

@wesbos wesbos merged commit 810e356 into wesbos:master Dec 14, 2016
@beausmith beausmith deleted the copy-pasta-hour branch December 15, 2016 18:34
EmmDguez pushed a commit to EmmDguez/JavaScript30 that referenced this pull request Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.