From 164f2972b5dfcf99fe818f7e3d37984417a1a723 Mon Sep 17 00:00:00 2001 From: kimkvn Date: Mon, 12 Dec 2016 13:50:47 -0500 Subject: [PATCH 1/6] hmm I should read up on es6 --- 01 - JavaScript Drum Kit/index-START.html | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/01 - JavaScript Drum Kit/index-START.html b/01 - JavaScript Drum Kit/index-START.html index 4070d32767..8bcf7d2a71 100644 --- a/01 - JavaScript Drum Kit/index-START.html +++ b/01 - JavaScript Drum Kit/index-START.html @@ -58,7 +58,11 @@ From e272191f140dc3fec2dd4b221a6b6806c1de3782 Mon Sep 17 00:00:00 2001 From: kimkvn Date: Mon, 12 Dec 2016 13:57:44 -0500 Subject: [PATCH 2/6] enable play on keypress --- 01 - JavaScript Drum Kit/index-START.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/01 - JavaScript Drum Kit/index-START.html b/01 - JavaScript Drum Kit/index-START.html index 8bcf7d2a71..0306034929 100644 --- a/01 - JavaScript Drum Kit/index-START.html +++ b/01 - JavaScript Drum Kit/index-START.html @@ -60,7 +60,9 @@ From 42d15320517f62c8226a51243259f2e76a9f15b3 Mon Sep 17 00:00:00 2001 From: kimkvn Date: Mon, 12 Dec 2016 14:28:42 -0500 Subject: [PATCH 3/6] writing listener to remove css class upon completion --- 01 - JavaScript Drum Kit/index-START.html | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/01 - JavaScript Drum Kit/index-START.html b/01 - JavaScript Drum Kit/index-START.html index 0306034929..002132088d 100644 --- a/01 - JavaScript Drum Kit/index-START.html +++ b/01 - JavaScript Drum Kit/index-START.html @@ -58,13 +58,28 @@ From 3fdb7705aafe178e1906b77d7a18b332eb42499c Mon Sep 17 00:00:00 2001 From: kimkvn Date: Mon, 12 Dec 2016 14:31:50 -0500 Subject: [PATCH 4/6] removing css class complete --- 01 - JavaScript Drum Kit/index-START.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/01 - JavaScript Drum Kit/index-START.html b/01 - JavaScript Drum Kit/index-START.html index 002132088d..b8acb654a3 100644 --- a/01 - JavaScript Drum Kit/index-START.html +++ b/01 - JavaScript Drum Kit/index-START.html @@ -74,7 +74,7 @@ function removeTransition(e){ if(e.propertyName !== 'transform') return; //skip if not transform - console.log(e.propertyName); + this.classList.remove('playing') } const keys = document.querySelectorAll('.key'); From 7389b427dc0fd8300b83b85f7b8906fdf69d56a3 Mon Sep 17 00:00:00 2001 From: kimkvn Date: Mon, 12 Dec 2016 14:35:32 -0500 Subject: [PATCH 5/6] separating playSound code into its own function --- 01 - JavaScript Drum Kit/index-START.html | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/01 - JavaScript Drum Kit/index-START.html b/01 - JavaScript Drum Kit/index-START.html index b8acb654a3..52bcdbb6f7 100644 --- a/01 - JavaScript Drum Kit/index-START.html +++ b/01 - JavaScript Drum Kit/index-START.html @@ -59,18 +59,16 @@ From 894bf60cf19c0f099a8440a980b1b0dc4318d47b Mon Sep 17 00:00:00 2001 From: kimkvn Date: Wed, 14 Dec 2016 01:40:57 -0500 Subject: [PATCH 6/6] decided to create a separate html file for my code, instead of writing it in the start file --- 01 - JavaScript Drum Kit/index-START.html | 21 ------ 01 - JavaScript Drum Kit/index-mine.html | 87 +++++++++++++++++++++++ 2 files changed, 87 insertions(+), 21 deletions(-) create mode 100644 01 - JavaScript Drum Kit/index-mine.html diff --git a/01 - JavaScript Drum Kit/index-START.html b/01 - JavaScript Drum Kit/index-START.html index 52bcdbb6f7..4070d32767 100644 --- a/01 - JavaScript Drum Kit/index-START.html +++ b/01 - JavaScript Drum Kit/index-START.html @@ -59,27 +59,6 @@ diff --git a/01 - JavaScript Drum Kit/index-mine.html b/01 - JavaScript Drum Kit/index-mine.html new file mode 100644 index 0000000000..52bcdbb6f7 --- /dev/null +++ b/01 - JavaScript Drum Kit/index-mine.html @@ -0,0 +1,87 @@ + + + + + JS Drum Kit + + + + + +
+
+ A + clap +
+
+ S + hihat +
+
+ D + kick +
+
+ F + openhat +
+
+ G + boom +
+
+ H + ride +
+
+ J + snare +
+
+ K + tom +
+
+ L + tink +
+
+ + + + + + + + + + + + + + + +