From bf6bd01665b2b7d5304bc45a253ea60af20da986 Mon Sep 17 00:00:00 2001 From: Jason Hanggi Date: Tue, 9 Oct 2018 20:02:38 -0500 Subject: [PATCH 1/2] Drum kit lesson 01 At least in current versions of chrome (69) and firefox (62), the keydown event has a `key` property, so there's no real reason here to use the keycodes. --- 01 - JavaScript Drum Kit/index-START.html | 57 ++++++++++++++++------- 1 file changed, 39 insertions(+), 18 deletions(-) diff --git a/01 - JavaScript Drum Kit/index-START.html b/01 - JavaScript Drum Kit/index-START.html index 4070d32767..a3364bb81e 100644 --- a/01 - JavaScript Drum Kit/index-START.html +++ b/01 - JavaScript Drum Kit/index-START.html @@ -9,56 +9,77 @@
-
+
A clap
-
+
S hihat
-
+
D kick
-
+
F openhat
-
+
G boom
-
+
H ride
-
+
J snare
-
+
K tom
-
+
L tink
- - - - - - - - - + + + + + + + + + From 9bda22300e811c5c6af1b054d59795cd4cbf5cb9 Mon Sep 17 00:00:00 2001 From: Jason Hanggi Date: Tue, 9 Oct 2018 20:28:35 -0500 Subject: [PATCH 2/2] [02] Clock Has a weird jump when the hand reaches the 0 and it transitions all the way around backwards. This is noted in the video. --- 02 - JS and CSS Clock/index-START.html | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/02 - JS and CSS Clock/index-START.html b/02 - JS and CSS Clock/index-START.html index 7cbf5f6ba6..e1e33a9b42 100644 --- a/02 - JS and CSS Clock/index-START.html +++ b/02 - JS and CSS Clock/index-START.html @@ -62,12 +62,31 @@ background: black; position: absolute; top: 50%; + transform-origin: 100%; + transform: rotate(90deg); + transition: all 0.05s; + transition-timing-function: cubic-bezier(0.1, 2.7, 0.58, 1); }