weixiao-huang
diff --git a/‎python/pip.bzl
Copy file name to clipboardExpand all lines: python/pip.bzl
+1-1Lines changed: 1 addition & 1 deletion b/‎python/pip.bzl
Copy file name to clipboardExpand all lines: python/pip.bzl
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎python/pip_install/pip_repository.bzl
Copy file name to clipboardExpand all lines: python/pip_install/pip_repository.bzl
+21-4Lines changed: 21 additions & 4 deletions b/‎python/pip_install/pip_repository.bzl
Copy file name to clipboardExpand all lines: python/pip_install/pip_repository.bzl
+21-4Lines changed: 21 additions & 4 deletions
@@ -20,7 +20,7 @@ load("//python/pip_install:requirements.bzl", _compile_pip_requirements = "compi
 compile_pip_requirements = _compile_pip_requirements
 package_annotation = _package_annotation
 
-def pip_install(requirements, name = "pip", **kwargs):
+def pip_install(requirements = None, name = "pip", **kwargs):
     """Accepts a `requirements.txt` file and installs the dependencies listed within.
 
     Those dependencies become available in a generated `requirements.bzl` file.
 
@@ -122,8 +122,8 @@ exports_files(["requirements.bzl"])
 def _pip_repository_impl(rctx):
     python_interpreter = _resolve_python_interpreter(rctx)
 
-    if rctx.attr.incremental and not rctx.attr.requirements_lock:
-        fail("Incremental mode requires a requirements_lock attribute be specified.")
+    # if rctx.attr.incremental and not rctx.attr.requirements_lock:
+    #     fail("Incremental mode requires a requirements_lock attribute be specified.")
 
     # We need a BUILD file to load the generated requirements.bzl
     rctx.file("BUILD.bazel", _BUILD_FILE_CONTENTS)
@@ -133,13 +133,24 @@ def _pip_repository_impl(rctx):
     annotations_file = rctx.path("annotations.json")
     rctx.file(annotations_file, json.encode_indent(annotations, indent = " " * 4))
 
+    os = rctx.os.name.lower()
+    requirements_txt = rctx.attr.requirements
+
+    if os.startswith("mac os") and rctx.attr.requirements_darwin != None:
+        requirements_txt = rctx.attr.requirements_darwin
+    elif os.startswith("linux") and rctx.attr.requirements_linux != None:
+        requirements_txt = rctx.attr.requirements_linux
+
+    if requirements_txt == None:
+        fail("Expected platform specific requirements attribute, or requirements to be set")
+
     if rctx.attr.incremental:
         args = [
             python_interpreter,
             "-m",
             "python.pip_install.parse_requirements_to_bzl",
             "--requirements_lock",
-            rctx.path(rctx.attr.requirements_lock),
+            rctx.path(requirements_txt),
             # pass quiet and timeout args through to child repos.
             "--quiet",
             str(rctx.attr.quiet),
@@ -159,7 +170,7 @@ def _pip_repository_impl(rctx):
             "-m",
             "python.pip_install.extract_wheels",
             "--requirements",
-            rctx.path(rctx.attr.requirements),
+            rctx.path(requirements_txt),
             "--annotations",
             annotations_file,
         ]
@@ -277,6 +288,12 @@ pip_repository_attrs = {
         allow_single_file = True,
         doc = "A 'requirements.txt' pip requirements file.",
     ),
+    "requirements_darwin": attr.label(
+        allow_single_file = True,
+    ),
+    "requirements_linux": attr.label(
+        allow_single_file = True,
+    ),
     "requirements_lock": attr.label(
         allow_single_file = True,
         doc = """