Create edit menu with Copy/Cut/Paste/Select All support by lukevers · Pull Request #237 · webview/webview

lukevers · Feb 14, 2019

Hi,

This adds support for the following actions on macOS:

Cut
Copy
Paste
Select All

It also adds it in an "Edit" menubar to follow the standards set by other macOS applications.

Here's a screenshot of it in an app I'm writing:

#99

travismiller · Feb 15, 2019

Awesome! This fixes cut/copy/paste for me on MacOS. 👍

travismiller · Feb 16, 2019

This will also add Undo/Redo…

  item = create_menu_item(get_nsstring("Undo"), "undo:", "z");
  objc_msgSend(editMenu, sel_registerName("addItem:"), item);

  item = create_menu_item(get_nsstring("Redo"), "redo:", "y");
  objc_msgSend(editMenu, sel_registerName("addItem:"), item);

  item = objc_msgSend((id)objc_getClass("NSMenuItem"), sel_registerName("separatorItem"));
  objc_msgSend(editMenu, sel_registerName("addItem:"), item);

lukevers · Feb 20, 2019

Thanks @travismiller! Just added that.

tobowers · Jun 3, 2019

Do I have to do something to turn this on? The latest commit ( 16c93bc ) doesn't have an edit menu for me on osx 10.14.5 . Even the examples directory ones.

tobowers · Jun 3, 2019

oh - just saw this is still open :)

brianm · Jun 7, 2019

Any chance this can get merged?

sbward · Jul 5, 2019

@zserge Are you considering merging this? I'm using JS "keypress" event listeners to work around this; the code smells bad but it works...

webview/webview/pull/237 webview/webview/pull/222 webview/webview/pull/214 Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev>

* feat(proton) cargo-bundle fork & features argument * chore(bundle) rename lib to proton-bundle * feat(proton.h) merge open PRs from webview webview/webview/pull/237 webview/webview/pull/222 webview/webview/pull/214 Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * feat(licenses) licenses and structure Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * addition to previous commit Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(version) of proton-sys in cargo.toml Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(various) use super: and remove 2018 Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(various) Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(rust-2018) update Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(rust-2018) update Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(rust-2018) add lockfiles Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(proton) includedir errors on prod build * fix(rust-2018) authors, lockfiles and newest stuff Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * feat(cargo-proton-bundle) update readme Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(proton) variable does not live long enough on dev * chore(proton) remove unnecessary global variable declaration

Adds edit menu based on webview/webview#237 Co-authored-by: Luke Evers <luke@lukevers.com> Co-authored-by: Travis Miller <travis@travismiller.com>

Adds edit menu for macOS apps, based on webview/webview#237 Co-authored-by: Luke Evers <luke@lukevers.com> Co-authored-by: Travis Miller <travis@travismiller.com>

brianm · Jan 9, 2020

bump

zserge · Jan 9, 2020

Well, since this is a macOS-only, highly specific feature (not every app needs such window menu at all) - I would rather close this. At some point we might want to add global window menu API and clipboard API, but before that I don't think such opinionated feature would be of much use for the majority of webview consumers.

Still, thanks for the PR, and I'm sure if will help those who would need such functionality for webview-x branch.

zserge · Jan 9, 2020

The reason I'm closing many PRs now is because I would like to merge webview-x first, with the very minimal core functionality. Then - extend window APIs for all platforms. We don't have much resources to do it all at the same time, thus - core functionality (actual webview, RPC) comes first, window decoration - next. And for window APIs I would like this time to have a well-though API, maybe similar to Electron, rather than one API function per user request.

lukevers · Jan 9, 2020

Makes sense @zserge! Anyone who is impatient can always take this code on their own when building locally 😉

* feat(proton) cargo-bundle fork & features argument * chore(bundle) rename lib to proton-bundle * feat(proton.h) merge open PRs from webview webview/webview/pull/237 webview/webview/pull/222 webview/webview/pull/214 Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * feat(licenses) licenses and structure Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * addition to previous commit Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(version) of proton-sys in cargo.toml Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(various) use super: and remove 2018 Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(various) Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(rust-2018) update Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(rust-2018) update Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(rust-2018) add lockfiles Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(proton) includedir errors on prod build * fix(rust-2018) authors, lockfiles and newest stuff Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * feat(cargo-proton-bundle) update readme Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev> * fix(proton) variable does not live long enough on dev * chore(proton) remove unnecessary global variable declaration

abemedia · Jun 21, 2020

@zserge Are you considering merging this? I'm using JS "keypress" event listeners to work around this; the code smells bad but it works...

@sbward could you share your workaround?

Create edit menu

f65993e

lukevers mentioned this pull request Feb 14, 2019

Cut/Copy/Paste hotkeys doesn't work on MacOS #99

Closed

mantou132 mentioned this pull request Feb 19, 2019

No Ctrl+Z/Ctrl+Shift+Z in text fields on gtk-webkit2 #119

Open

Add undo/redo support for macOS

0e3bf72

nothingismagick pushed a commit to tauri-apps/tauri that referenced this pull request Jul 20, 2019

feat(proton.h) merge open PRs from webview

12e786b

webview/webview/pull/237 webview/webview/pull/222 webview/webview/pull/214 Signed-off-by: Daniel Thompson-Yvetot <denjell@quasar.dev>

KoStard mentioned this pull request Dec 19, 2019

Is there a way to add MenuBar and MenuItems? Boscop/web-view#104

Open

rajivshah3 added a commit to rajivshah3/web-view that referenced this pull request Jan 8, 2020

cocoa: Create edit menu

f54204f

Adds edit menu based on webview/webview#237 Co-authored-by: Luke Evers <luke@lukevers.com> Co-authored-by: Travis Miller <travis@travismiller.com>

rajivshah3 added a commit to rajivshah3/web-view that referenced this pull request Jan 8, 2020

cocoa: Create edit menu

c05ed59

Adds edit menu for macOS apps, based on webview/webview#237 Co-authored-by: Luke Evers <luke@lukevers.com> Co-authored-by: Travis Miller <travis@travismiller.com>

rajivshah3 mentioned this pull request Jan 8, 2020

cocoa: Create edit menu Boscop/web-view#125

Closed

zserge closed this Jan 9, 2020

abemedia mentioned this pull request Jun 21, 2020

Keyboard shortcuts (Cmd+C, Cmd+V etc.) not working on macOS #397

Open

abemedia mentioned this pull request Jun 21, 2020

Is it possible to add cocoa menubar items? #398

Closed

abemedia mentioned this pull request Jul 23, 2020

[macOS] Private API usage #425

Open

ttytm mentioned this pull request Aug 11, 2023

feat: menu items on Mac (maybe also other OSs?) ttytm/webview#6

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create edit menu with Copy/Cut/Paste/Select All support#237

Create edit menu with Copy/Cut/Paste/Select All support#237
lukevers wants to merge 2 commits intowebview:masterwebview/webview:masterfrom
lukevers:edit-menulukevers/webview:edit-menuCopy head branch name to clipboard

lukevers commented Feb 14, 2019 •

edited

Loading

Uh oh!

travismiller commented Feb 15, 2019

Uh oh!

travismiller commented Feb 16, 2019 •

edited

Loading

Uh oh!

lukevers commented Feb 20, 2019

Uh oh!

tobowers commented Jun 3, 2019

Uh oh!

tobowers commented Jun 3, 2019

Uh oh!

brianm commented Jun 7, 2019

Uh oh!

sbward commented Jul 5, 2019

Uh oh!

brianm commented Jan 9, 2020

Uh oh!

zserge commented Jan 9, 2020

Uh oh!

zserge commented Jan 9, 2020

Uh oh!

lukevers commented Jan 9, 2020

Uh oh!

abemedia commented Jun 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

Search code, repositories, users, issues, pull requests...

Conversation

lukevers commented Feb 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

travismiller commented Feb 15, 2019

Uh oh!

travismiller commented Feb 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukevers commented Feb 20, 2019

Uh oh!

tobowers commented Jun 3, 2019

Uh oh!

tobowers commented Jun 3, 2019

Uh oh!

brianm commented Jun 7, 2019

Uh oh!

sbward commented Jul 5, 2019

Uh oh!

brianm commented Jan 9, 2020

Uh oh!

zserge commented Jan 9, 2020

Uh oh!

zserge commented Jan 9, 2020

Uh oh!

lukevers commented Jan 9, 2020

Uh oh!

abemedia commented Jun 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

lukevers commented Feb 14, 2019 •

edited

Loading

travismiller commented Feb 16, 2019 •

edited

Loading