Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Race condition in WebSocketApp #1002

Copy link
Copy link
@pfaion

Description

@pfaion
Issue body actions

Hey, thanks for maintaining this library!

I apologize because this is not a good bug report. I don't have logs or a reproducible example. But I ran into an issue once that I cannot reproduce now and I think I tracked it down to possible race conditions in WebSocketApp.

I see WebSocketApp.run_forever() and WebSocketApp.close() both mutate self.sock and self.keep_running. So when calling them from different threads, those calls might interleave and produce data races, where the socket is not properly closed.

I'm pretty sure that's the issue I saw. Again, apologies for no concrete examples, but I thought it would be worth bringing this to your attention!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.