Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Explain the externals string syntax specifying externalsType #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 8, 2022

Conversation

tanhauhau
Copy link
Contributor

@tanhauhau tanhauhau commented Aug 5, 2022

Explain the externals string syntax specifying externalsType

Fixes #4148
Fixes #5928

@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webpack-js-org ✅ Ready (Inspect) Visit Preview Aug 8, 2022 at 6:26AM (UTC)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 5, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank u for those examples! I've made some feedback.

src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
Co-authored-by: Sam Chen <chenxsan@gmail.com>
src/content/configuration/externals.mdx Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
src/content/configuration/externals.mdx Outdated Show resolved Hide resolved
@chenxsan chenxsan merged commit b355406 into webpack:master Aug 8, 2022
@tanhauhau tanhauhau deleted the patch-1 branch August 8, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation contains no example for externals: string Misleading documentation on externals type or potential bug
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.