feat(cache): Add cacheFilter option to limit asset caching #19363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents large asset module data from bloating the filesystem cache. Introduces a configurable option to skip caching large binary data, improving cache size and build performance
alexander-akait
requested changes
Mar 26, 2025
There was a problem hiding this comment.
Please avoid sending feature requests before discussion, otherwise you lose your time.
This is not a universal solution and we should avoid them.
cacheFilter should be just a function and we should pass identifier and data to this function, so developer will write own behavior (it can be based on size, identifier/etc), other non official plugins can store binary assets too and current solution will not solve such problem
|
okay mistake from my side i will keep this in mind but what can be correct solution from your point of view i think we should implement this thing and add on some more things which you are telling |
|
Just make it a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19359
This PR introduces a feature by adding a new configuration option (
cache.cacheFilter.maxAssetSize) to the filesystem cache system. It includes:IdleFileCachePlugin.jsto filter assets based on size.applyCacheDefaultsinlib/config/defaults.jsto set a defaultmaxAssetSizeof 2048 bytes.