fix: add strict: true to ContextModule
#19327
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -435,6 +435,7 @@ class ContextModule extends Module { | ||
| defaultObject: "redirect-warn" | ||
| }; | ||
| this.buildInfo = { | ||
| strict: true, |
There was a problem hiding this comment.
We should pass the option here or infer them from something, otherwise it is a breaking change
There was a problem hiding this comment.
I think most of the code in ContextModule is generated by Webpack. So it's fine to make it from non-strict to strict.
There was a problem hiding this comment.
Most, but not all, so we need to use option here, to avoid broken code
| module.exports = options => { | ||
| if (options.cache && options.cache.type === "filesystem") { | ||
| return [/Pack got invalid because of write to/]; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #18367 (comment), we aim to enforce strict mode across all modules to eliminate the entry IIFE.
But the
module.parser.javascript.overrideStrictoption cannot apply toContextModules.What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing