fix attempt: enable export mangling for modules used only as export objects #19219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
lib/ExportsInfo.js:402
- The new method
setUsedAsExportObjectshould be covered by tests to ensure it behaves as expected.
setUsedAsExportObject(runtime) {
lib/FlagDependencyUsagePlugin.js:93
- The new behavior introduced by setUsedAsExportObject should be covered by tests to ensure correctness and prevent regressions.
if (exportsInfo.setUsedAsExportObject(runtime)) {
lib/optimize/MangleExportsPlugin.js:25
- The removal of this check might change the intended behavior of the canMangle function. Please ensure this change is intentional and doesn't introduce any bugs.
if (exportsInfo.otherExportsInfo.getUsed(undefined) !== UsageState.Unused)
|
Looks like a problem with |
|
@scameron from failing test cases i can think there is some error in the code style in which you have written try to fix that and re run the yarn test --basic to see further outputs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at a fix for issue #19153. I'm almost certain that this is wrong, but it seems to work in my case. The hope is that running this through the automated tests will show more info about specifically what is wrong with this.
I tried this in my full production build and it succeeds there as well. The chunk size is reduced by nearly 3MB overall after this change (in an enormous 484MB build, but still).
What kind of change does this PR introduce?
In cases where a depency has no specific used exports, but instead is used as an "export object" via an export of
import *, we no longer mark the usage as "unknown" but instead mark it as used.Did you add tests for your changes?
No new tests. This is an experiment to see what existing tests break.
Does this PR introduce a breaking change?
Not sure yet...
What needs to be documented once your changes are merged?
No documentation