[Form] getParent() does not receive correct options array #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. Unfortunately there is no way this could ever work. In order to determine the specific options used to instantiate a form, you'd have to know the complete inheritance tree. So you cannot know the options when building the tree. I'm starting to think that this whole dynamic inheritance thing is flawed. |
|
On a side note, please try to name PRs and tickets in a meaningful way. This makes our lives much easier :) I changed the name of this PR now. |
|
Ah, I just noticed that you opened this PR in my repository. Please reopen it in the symfony/symfony repository in order to make it visible for other collaborators as well. Usually we don't deal with issues or PRs in collab repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote two tests which show exactly what functionality was broken by PR symfony#3290. Unfortunately one of them (testChildDefaultOptionIsPassedToChildsGetParentMethod) is still broken after PR symfony#3789.
The default options of children or even the type itself are still not passed to the getParent method, forcing users to pass these options to the factory every time they use the type. A more specific use case is when you create a type which has "choice" as it's parent. When in its default options it defines "expanded"=>true and "multiple"=>true, the getParent() of the "choice" type should always return "form", otherwise a dataMapper will never be assigned and the checkbox list shows empty, even if some values are "true".
At this moment the getParent method reads as follows:
If the option was not passed to the factory (e.g. from the controller), it seems to just assume the form is not "expanded", which sounds wrong to me.
Hopefully this test can help fix the problem!