-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: update waitForExist function to maintain elementIds for shadow e… #14836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
christian-bromann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
create-wdio
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
@wdio/xvfb
webdriver
webdriverio
commit: |
|
Hey b-kirby 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
Proposed changes
Adds a small change to the
waitForExistfunction for and edge case that causes theswitchFramefunction to fail with an undefined elementId when passing in a shadow Element.The impact of the problem occurs in this part of the switchFrame logic:
webdriverio/packages/webdriverio/src/commands/browser/switchFrame.ts
Line 296 in e86efcc
The issue is hard to detect as it has no impact in most cases due to the internal logic and the return type.
In this scenario the function correctly returns true but it also resets the global elementId to be undefined due to this line:
webdriverio/packages/webdriverio/src/commands/element/waitForExist.ts
Line 68 in e86efcc
Because the element being passed into the function is a shadow element, the parent is unable to find the element based on the provided selector.
Inside the switchFrame function the elementId is now undefined prior to calling
which results in an error similar to the following:
The fix is intended to be the least invasive approach with minimal impact to the underlying functionality in most cases.
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers