Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(webdriverio): Fix request mock with hostname only not working #14817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christian-bromann merged 3 commits into from
Nov 22, 2025
Merged

fix(webdriverio): Fix request mock with hostname only not working #14817

christian-bromann merged 3 commits into from
Nov 22, 2025

Conversation

@Dziurdzikowski
Copy link
Contributor

@Dziurdzikowski Dziurdzikowski commented Oct 16, 2025 •
edited
Loading

Proposed changes

WebDriver V8 was working fine when used with regex for any path on specific domain to be mocked.
Right now I'm working on upgrade to V9 and it's completely not possible to create mock for such a scenario.

Example below shows what right now is completely not working while at least 2 of presented cases should

const myApiUrl = 'http://my.super.api';
// OR const myApiUrl = 'http://my.super.api/*';
// OR const myApiUrl = 'http://my.super.api/**';
// OR const myApiUrl = '**';  - That one is even described in docs...

const browserMock = await browser.mock(myApiUrl);
browserMock.on('request', (request) => {
  console.log('req', request); // Never executed
});

// then fetch in browser URL http://my.super.api/my/books.php?category=fantasy

after change both 'http://my.super.api' and '*' will trigger request as expected.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 16, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: christian-bromann / name: Christian Bromann (13d38be)

@fpereira1 fpereira1 mentioned this pull request Oct 27, 2025
Closed
3 tasks
christian-bromann
christian-bromann approved these changes Nov 14, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mauriciolauffer mauriciolauffer mentioned this pull request Nov 20, 2025
Open
@mauriciolauffer
Copy link
Contributor

mauriciolauffer commented Nov 20, 2025

@christian-bromann it seems this PR has been approved, but not merged yet. Is the anything I can do to help merging and publishing it?

@christian-bromann
Copy link
Member

christian-bromann commented Nov 21, 2025

Is the anything I can do to help merging and publishing it?

There is a build issue in main which we need to resolve first.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 22, 2025

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@14817

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14817

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14817

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14817

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14817

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14817

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14817

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14817

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14817

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14817

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14817

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14817

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14817

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14817

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14817

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14817

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14817

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14817

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14817

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14817

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14817

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14817

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14817

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14817

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14817

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14817

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14817

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14817

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14817

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14817

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14817

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14817

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14817

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14817

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14817

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14817

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@14817

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14817

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14817

commit: 13d38be

@christian-bromann christian-bromann merged commit c7bba51 into webdriverio:main Nov 22, 2025
33 checks passed
@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 22, 2025
@wdio-bot
Copy link
Contributor

wdio-bot commented Nov 22, 2025

Hey Dziurdzikowski 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@mccmrunal mccmrunal mentioned this pull request Dec 17, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

Expensable $25 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dziurdzikowski @mauriciolauffer @christian-bromann @wdio-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.