🐛⏪️ revert: "tsConfigPath in wdio.conf (#14664)" #14802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create-wdio
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
@wdio/xvfb
webdriver
webdriverio
commit: |
bbfadfc to
3b3e671
Compare
7c7c898 to
6cc8c32
Compare
8e7579e to
0c817f3
Compare
Contributor
Author
|
Hi @christian-bromann, I seem to be able to merge without anyone reviewing this PR, but I wanted to run it past you first seeing as you were involved in the original PR. As per the description it removes Jiti again after I added it in #14664. Jiti does not play nicely with full typescript projects! The rest of the changes were just trying to get the pipeline working. I don't think that I've changed what is tested, only how the runners handle things, but I'd appreciate a check before I merge. 👍 |
This reverts most of commit 6173b79. The introduction of jiti caused significant regressions for users with complex `wdio.conf.ts` files, as reported in webdriverio#14801. This change restores the previous import mechanism to resolve these issues. It retains the attempt to load the config file and parse the tsConfigPath setting from it, with a cache-busting mechanism to prevent Node from caching failed imports. Documentation has been updated to explain the limitations of this configuration method. Fixes webdriverio#14801
An example of the warning in the test logs:
```
Promise returned by `expect(actual).rejects.toThrowError(expected)` was not awaited. Vitest currently auto-awaits hanging assertions at the end of the test, but this will cause the test to fail in Vitest 3. Please remember to await the assertion.
at /home/steve/dev/webdriverio/packages/wdio-shared-store-service/tests/client.test.ts:38:43
```
0c817f3 to
7acc113
Compare
Contributor
Author
|
Hi @christian-bromann, I've rebased on to main & resolved an issue with another flaky test. Is there anything else I can do to help get this merged? |
Contributor
|
Hey sh41 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This reverts most of #14664 / commit 6173b79.
The introduction of jiti caused significant regressions for users with complex
wdio.conf.tsfiles, as reported in #14801. This change restores the previous import mechanism to resolve these issues.It retains the attempt to load the config file and parse the tsConfigPath setting from it, with a cache-busting mechanism to prevent Node from caching failed imports. Documentation has been updated to explain the limitations of this configuration method.
Fixes #14801
Types of changes
Checklist
Backport Request
v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers