This repository was archived by the owner on Mar 5, 2025. It is now read-only.
coverage increase #7051
Merged
coverage increase #7051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 19602ab | Previous: f4e55bd | Ratio |
|---|---|---|---|
processingTx |
8890 ops/sec (±4.02%) |
9157 ops/sec (±3.53%) |
1.03 |
processingContractDeploy |
39552 ops/sec (±6.70%) |
39854 ops/sec (±6.49%) |
1.01 |
processingContractMethodSend |
18468 ops/sec (±8.65%) |
19031 ops/sec (±8.97%) |
1.03 |
processingContractMethodCall |
37510 ops/sec (±5.77%) |
37579 ops/sec (±6.24%) |
1.00 |
abiEncode |
42293 ops/sec (±6.73%) |
42781 ops/sec (±6.77%) |
1.01 |
abiDecode |
29068 ops/sec (±8.33%) |
29806 ops/sec (±7.94%) |
1.03 |
sign |
1541 ops/sec (±0.64%) |
1522 ops/sec (±3.29%) |
0.99 |
verify |
356 ops/sec (±2.71%) |
368 ops/sec (±0.73%) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
avkos
approved these changes
May 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7051 +/- ##
==========================================
+ Coverage 91.97% 92.21% +0.24%
==========================================
Files 215 215
Lines 8291 8329 +38
Branches 2277 2296 +19
==========================================
+ Hits 7626 7681 +55
+ Misses 665 648 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Jul 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7032
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.