fix(type): Add the missing types to the ”accounts“ #6762
Conversation
There was a problem hiding this comment.
Thanks @electroluxcode for your catch and the MR.
Could you please respond to the suggestion below. And update the packages/web3/CHANGELOG.md file?
It will be also nice and helpful to write small Unit tests inside the web3 package for those added functions.
Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
f17280e to
54e229c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6762 +/- ##
==========================================
+ Coverage 87.37% 92.03% +4.65%
==========================================
Files 197 214 +17
Lines 7548 8171 +623
Branches 2059 2200 +141
==========================================
+ Hits 6595 7520 +925
+ Misses 953 651 -302
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@electroluxcode could you fix conflicting file and above comments, Thanks |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
|
closing this PR as it will be merged via #7011 Thanks @electroluxcode |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.According to the documentation at https://docs.web3js.org/libdocs/Accounts, add the missing types to the account