test: rewrite hot test cases with NEXT_HMR #11882
Merged
+1,706
−1,917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR rewrites the hot test cases to use the new NEXT_HMR API instead of the legacy callback-based NEXT function for hot module replacement updates, significantly simplifying the test code structure. The changes also include removal of legacy helper files and update the HMR test infrastructure.
- Refactored test cases from Promise-based callback pattern to async/await using
NEXT_HMR() - Removed legacy update helper files (
update.js,update.esm.js) - Updated test infrastructure to handle the new HMR API pattern
Reviewed Changes
Copilot reviewed 171 out of 171 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
Various index.js test files |
Converted from callback-based HMR tests to async/await pattern with NEXT_HMR |
update.js and update.esm.js |
Removed legacy update helper modules |
| Snapshot files | Updated to reflect new test execution patterns |
loader.ts and plugin.ts |
Updated HMR test infrastructure to support new API |
| Various test configuration files | Added module.hot.accept calls where missing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📦 Binary Size-limit
🙈 Size remains the same at 47.67MB |
CodSpeed Performance ReportMerging #11882 will not alter performanceComparing Summary
|
91e1dab to
d7d1a18
Compare
9aoy
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related links
Checklist