chore: Using env to enable sftrace #11880
Merged
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR changes the sftrace feature enablement from automatic activation in release-debug profile on specific platforms to manual enablement via the SFTRACE environment variable. This resolves symbol resolution issues on Linux debug profiles where weak linking cannot be configured.
- Replaces platform-specific conditional logic with environment variable check
- Removes automatic symbol mangling configuration
- Simplifies sftrace feature activation mechanism
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
62ceb4d to
7e7247f
Compare
📦 Binary Size-limit
🙈 Size remains the same at 47.66MB |
CodSpeed Performance ReportMerging #11880 will not alter performanceComparing Summary
|
SyMind
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use env to enable sftrace support instead of enalbe it auto. this prevents the debug profile from not find symbols on Linux (because we cannot configure weak link).
Related links
Checklist