Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0892a2c

Browse filesBrowse files
committed
Merge pull request symfony#725 from lsmith77/patch_check_list
[WIP] Patch check list
2 parents 0649201 + 6fd71e0 commit 0892a2c
Copy full SHA for 0892a2c

File tree

Expand file treeCollapse file tree

1 file changed

+40
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+40
-0
lines changed

‎contributing/code/patches.rst

Copy file name to clipboardExpand all lines: contributing/code/patches.rst
+40Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,46 @@ Submitting a Patch
44
Patches are the best way to provide a bug fix or to propose enhancements to
55
Symfony2.
66

7+
Check List
8+
----------
9+
10+
The purpose of the check list is to ensure that contributions may be reviewed
11+
with needless feedback loops to ensure that your contributions can be included
12+
into Symfony2 as quickly as possible.
13+
14+
.. warning::
15+
16+
All pull requests should include the following template in the request
17+
description:
18+
19+
.. code-block:: plain
20+
21+
Bug fix: [yes|no]
22+
Feature addition: [yes|no]
23+
Backwards compatibility break: [yes|no]
24+
Symfony2 tests pass: [yes|no]
25+
Fixes the following tickets: [comma separated list of tickets fixed by the PR]
26+
27+
An example submission could now look as follows:
28+
29+
.. code-block:: plain
30+
31+
Bug fix: no
32+
Feature addition: yes
33+
Backwards compatibility break: no
34+
Symfony2 tests pass: yes
35+
Fixes the following tickets: -
36+
37+
Thank you for including the filled out template in your submission!
38+
39+
.. tip::
40+
41+
All feature addition's should be send to the "master" branch, while all
42+
bug fixes should be send to the oldest still active branch. Furthermore
43+
submissions should as a rule of thumb not break backwards compatibility.
44+
Please mark any submissions as "[WIP]" in the title in case the submission
45+
is not yet complete (for example if the tests do not yet pass).
46+
747
Initial Setup
848
-------------
949

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.