Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

🎨 Add redesign of Techniques, Understanding templates #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 66 commits into from
Closed

Conversation

hidde
Copy link
Member

@hidde hidde commented Aug 24, 2021

Preview of Techniques / Preview of Understanding documents

Overview of updates

Summary

With the new design, we now:

  • clearly mark these documents as part of W3C (logo), part of WAI (colors, layout, fonts), part of WCAG (WCAG is the first word on the page)
  • show clearly which set of documents the user is looking at, including which version of WCAG they belong to (2.1, 2.2 etc)
  • have clear pointers to other supporting documents and the general “All WCAG Guidance”
  • use a lay-out that is also used by other supporting docs (soon: ACT Rules, COGA Design Guide)
  • visually distinguish between name of the document (eg “Using aria-label for link purpose”), how it fits in the larger set (“Sufficient to meet 2.4.4”), the actual document content, meta information (eg links to other sources, summary of key terms, definition of the document type)
  • invite people to contribute (“Help improve this page”)
  • make code examples easier to use (with syntax highlighting
  • have both ‘created’ and ‘last updated’ dates on each document

(see Requirements Analysis)

For AGWG approval

Techniques

For AGWG consideration

Techniques

  • In the applicability section, we replace some common technologies with their abbreviations (eg “HTML” instead of “HyperText Markup Language”), to be closer to how people commonly refer to these technologies. They are wrapped in an abbr tag as well as a link to their specification, so confusion should be minimal for those not familiar with the abbreviation.
  • Applicabiliity (eg technologies the Technique applies to) is now its own section
  • The relationship of a Technique with an SC is displayed in a box underneath the name of the Technique, in the form of a sentence, with type emphasised (Advisory for, Failure of, etc). There are many variations, some examples:
    • when used with: “This technique is Sufficient to meet 1.2: Time-based Media when used with G87: Providing closed captions. ”
    • advisor for: “This technique is Advisory for 3.1: Readable.“
    • sufficient for two: “This technique is: Sufficient to meet 1.1: Text Alternatives and Sufficient to meet 2.4: Navigable “

Understanding

  • The “key terms” now just has terms that link to WCAG, not the full definition
  • On the “All Understanding documents” page documents are now split out between “Other Understanding documents”
  • Previous/Next GL, Previous Success Criterion are now Previous/Next Guideline, Previous/Next Success Criterion

Other updates

  • Adds more of the generated files / build artifacts to .gitignore so that they don't end up in the repository (and don't end up causing merge conflicts)

Open questions

  • Technique H43 and others are “sufficient when used with an unwritten Technique”. This is displayed for technical reasons, but may leave users confused. Should we display only “sufficient” (technically not 100% correct)? Or should we mark these as advisory until the unwritten Technique is written?

To do

Techniques and Understanding

  • In footer, use correct date for “Last updated”, ideally reflecting when that specific Technique/Understanding was last updated (Note 25 October (Hidde): there is some talk in #74 about maybe removing “Last updated :@@@” from these templates, so that this task could be done after publication): relevant: Comment on WCAG 2.2 Draft: please delay adding of new Success Criteria before the current documentation is improved. #1818 (comment)
  • Rethink expand/collapse usage re AGWG/Team comments: either use table of contents instead or add ‘expand/collapse all’ with (probably) remembering the choice in localStorage (Hidde feels that route would also require a way to reset, maybe even a different control?)

Techniques specifically

none open

Understanding pages specifically

  • Ensure a maximum of two items in the pager (#navigation) at the bottom of the page, there can be one previous and one next (example of where more than two items are displayed: Understanding ACT Rules, pager)
  • Make “Key terms” links to their definitions in the WCAG TR document; both inside the content and in the “About this page” box (Note 25 October (Hidde): in #68, it is being doubted whether we should to this at all)

@hidde hidde changed the title Tweak templates and styles 🎨 Add redesign of Techniques, Understanding templates Aug 24, 2021
@hidde hidde marked this pull request as draft August 24, 2021 14:18
@hidde hidde force-pushed the redesign branch 7 times, most recently from a38c7cd to dfc0048 Compare August 25, 2021 08:46
@hidde hidde force-pushed the redesign branch 4 times, most recently from 97f92dd to 4f16b99 Compare September 24, 2021 11:00
Signed-off-by: Hidde de Vries <hidde@hiddedevries.nl>
@michael-n-cooper
Copy link
Member

I've address and checked off most of the issues. Comments / questions on ones not complete:

  • header should say “WCAG 2.x: Techniques” - I believe that code is already in place, don't see anything to fix unless I've missed something.
  • In footer, use correct dates for “Last updated” and “First Published” - I added the current date for last updated. It might be possible to get the date of the last commit, but I haven't tried that yet. I have no idea what to put for First Published though. We don't have tracking of a sort that would allow us to pull and maintain accurate information about this.
  • In “About Techniques”, we've included the Changelog and Acknowledgments - I made the acknowledgements an include. I don't know what to do for the changelog though, it reads to me like something we'd be maintaining manually, so it would need to be updated in that file unless it's shared somehow with other resources. We don't have a good set-up right now for automatic changelog generation.
  • Remove “Level” on pages that are not about a Success Criterion - I couldn't find any examples of that.
  • Ensure a maximum of two items in the pager - I couldn't find any that had more than 2.
  • Make “Key terms” links to their definitions in the WCAG TR document - does this mean link the term but still include its definition, link it and don't copy through the definition, or something else?

hidde added 3 commits October 11, 2021 14:37
Signed-off-by: Hidde de Vries <hidde@hiddedevries.nl>
Signed-off-by: Hidde de Vries <hidde@hiddedevries.nl>
Signed-off-by: Hidde de Vries <hidde@hiddedevries.nl>
@shawna-slh
Copy link
Contributor

For those interested in the UI and visual design:
EOWG, COGA TF, Rules TF, @SteveALee and @shawna-slh have been iterating through user feedback to refine the UI to meet identified user needs – including frequent users and people who land on a page from search without knowing WCAG. We plan to use the same design for Understanding, Techniques, Supplemental Guidance (currently from the COGA/Content Usable doc, later also from LVTF/AG), and Rules. Key aspects include:

  • Clearly stating up front that these are not required to meet WCAG
  • Providing navigation to previous and next Understanding doc near the top of the page, where existing users are used to it
  • Providing content in similar visual and DOM order for common views, zoomed, large text, and screen reader users (i.e., sidebar near top of DOM)
  • Providing link to “About” where it is easy for newbies to find and repeat users to ignore

Please see:

We are planning to publish these soon as “Phase 1” while we continue to make refinements. We welcome additional issues in the parent repo.

@hidde
Copy link
Member Author

hidde commented Apr 13, 2022

I'll close my pull request as to not associate myself with these changes, I think they make things more confusing than they already are. It's a shame the simplifications and UI elements the working group and I worked on and got ready for release many months ago have been removed. The PR description when opening this thus no longer applies.

Whoever wants these changes can open their own pull request to main from the redesign branch.

@hidde hidde closed this Apr 13, 2022
@mbgower
Copy link
Contributor

mbgower commented Apr 18, 2022

@hidde I can't entirely follow the changes about which you have concerns. I infer there is some background discussion and that you feel opposing interests have marred some useful suggested changes?
If there's anything here you need to refocus agwg attention on, please provide details.

@hidde
Copy link
Member Author

hidde commented Apr 21, 2022

@mbgower have you followed the changes from October to now? It was pretty much ready to go in October and instead of going live (after almost 2 years of collaboration), the redesign has been taken apart and essential usability features removed. It no longer meets the requirements in the requirements analysis we developed at EOWG.

I would be happy to talk to AGWG or individual members of AGWG about what happened, in fact, please reach out to me, but, after having been involved with this redesign project for all this time, I can no longer do work on this (but we could still revert back to October state).

Best of luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.