-
-
Notifications
You must be signed in to change notification settings - Fork 44
added localization support #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
VisualAlf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very clean design !!
some minor flaws:
TableViewDateColumn:
Line 67: this always stays as 'pick a date'. since the DP has a default. Consider dropping the DependencyProp.
TableViewColumnHeader.xaml:
Line 158: remove PlaceholderText in Autosuggestbox, since set in code.
TableViewTimeColumn:
missing Placeholder setter for TimePickerControl
TableViewTimePicker:
consider dropping PlaceHolder DP
TableViewColumnHeader:
consider dropping Descriptions for 'SelectAll', 'DeselectAll', 'Copy', and 'CopyWithHeaders', since they are sort of redundant, and well described in the command.
TableViewLocalizedStrings.GetValue(string name)
I don't understand why you need TryGetValue(..) and then GetValue(..) if first returns null ??
|
Very nice Implementation, I shortly tested it in my Application and it was working well. I have some suggestions, since we don't have many strings, why not add strings for all Languages into the Library by doing community translations, there are many free services that generate resx files from user inputs, users can review changes made by others and submit new translations. Or we could start with sample machine translations. |
@Bush-cat Thanks for your suggestion! I completely agree that having translations for all languages would be great. For now instead of using Crowdin, I’d prefer to accept translation contributions directly on GitHub. Feel free to open a PR with your own language translations—we’d really appreciate it! |
Thank you, @VisualAlf! I've made the changes and am merging the PR now. Regarding the descriptions, they are just tooltips for the menu items. As for your last point about TryGetValue, the reason for that is if the resource isn't found, the next line ensures it falls back to the default language resource. |
Description
This PR introduces localization support for WinUI.TableView, allowing users to add resource files for their desired languages. This was a long-awaited enhancement request, and it is now implemented.
.reswfiles.WinUI.TableView.reswunderStrings/{language name}/.Microsoft.Windows.Globalization.ApplicationLanguages.PrimaryLanguageOverrideSample resources: