vyaasp
diff --git a/‎build-ffmpeg
Copy file name to clipboardExpand all lines: build-ffmpeg
+9Lines changed: 9 additions & 0 deletions b/‎build-ffmpeg
Copy file name to clipboardExpand all lines: build-ffmpeg
+9Lines changed: 9 additions & 0 deletions
@@ -375,6 +375,9 @@ if build "autoconf" "2.71"; then
 	build_done "autoconf" "2.71"
 fi
 
+# TODO: this didn't successfully install meson in a place on my path so any meson commands failed for me.
+# See https://github.com/mesonbuild/meson/issues/1613 for more context. 
+
 if build "meson"; then
 	execute python3 -m pip install meson ninja
 	build_done "meson"
@@ -477,6 +480,8 @@ fi
 	CONFIGURE_OPTIONS+=("--enable-libx264")
 # fi
 
+# TODO: we should probably check with steve about what to do here re: liscensing - matt
+
 # if $NONFREE_AND_GPL; then
 # 	if build "x265" "3.5"; then
 # 		download "https://github.com/videolan/x265/archive/Release_3.5.tar.gz" "x265-3.5.tar.gz" # This is actually 3.4 if looking at x265Version.txt
@@ -597,6 +602,8 @@ if build "twolame"; then
 fi
 CONFIGURE_OPTIONS+=("--enable-libtwolame")
 
+# TODO: not sure if we need this but it was also failing for me at the set_mac_install_name line below - matt
+
 # if build "av1" "ae2be80"; then
 # 	# libaom ae2be80 == v3.1.2
 # 	download "https://aomedia.googlesource.com/aom/+archive/ae2be8030200925895fa6e98bd274ffdb595cbf6.tar.gz" "av1.tar.gz" "av1"
@@ -795,6 +802,8 @@ CONFIGURE_OPTIONS+=("--enable-libspeex")
 ## image library
 ##
 
+# TODO: re-enable? this failed to build even in a clean checkout of the ffmpeg-build-script repo. - matt
+
 # if build "libtiff" "4.3.0"; then
 # 	download "https://download.osgeo.org/libtiff/tiff-4.3.0.tar.gz"
 # 	execute ./configure --prefix="${WORKSPACE}" --enable-shared --disable-static