refactor(vOnClickOutside): use weakMap for stop function instead of mutating element #4755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lement and save handler in weakmap
43081j
reviewed
May 15, 2025
| }, | ||
| unmounted(el) { | ||
| (el as any).__onClickOutside_stop() | ||
| const stop = stopClickOutsideMap.get(el) | ||
| if (stop && typeof stop === 'function') { |
There was a problem hiding this comment.
if it isn't a function, it means controls was true, right?
so we should just call stop() on it I think:
if (typeof stop === 'function') {
stop();
} else {
stop.stop(); // but call the variable something better
}There was a problem hiding this comment.
thx for your reply！
Yes, you're right. I overlooked this logic branch and I will add this new logic
There was a problem hiding this comment.
I have added this logic. thx you for your guidance！
antfu
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
optimize the vOnClickOutside method , remove handler form element and save handle to weak map.
This can prevent external operations on the methods mounted on the element, thereby avoiding some unexpected behaviors