fix(useColorMode): support passing nonce #4754
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrbisK
reviewed
May 15, 2025
Comment on lines
+190
to
+192
| if (nonce) { | ||
| style.nonce = nonce | ||
| } |
There was a problem hiding this comment.
@43081j maybe we want to go for styleAttributes here? should not be breaking for this.
I wonder if we should use useStyleTag here
There was a problem hiding this comment.
that probably makes sense 👍
styleAttributes here, attributes (eventually) in useStyleTag
and you're right this could use useStyleTag, but not necessarily in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).Description
#4741
#4749（pr）
Since I'm not sure if the pull request for useColorMode can pass your review, I didn't improve useColorMode at that time. Now, the solution for useColorMode is the same as that for useStyleTag.
Additional context