fix(fromEvent): fix type error of element reference #4728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyaliao
reviewed
Apr 25, 2025
packages/rxjs/toObserver/index.md
Outdated
| @@ -16,6 +16,8 @@ import { shallowRef } from 'vue' | ||
|
|
||
| const count = shallowRef(0) | ||
| const button = shallowRef<HTMLButtonElement | null>(null) |
There was a problem hiding this comment.
I think we can just change it to useTemplateRef.
packages/rxjs/README.md
Outdated
| @@ -35,7 +35,9 @@ import { concatAll, map, mergeMap, pluck, scan, take } from 'rxjs/operators' | ||
| import { ref } from 'vue' | ||
|
|
||
| const BASE_URL = 'https://jsonplaceholder.typicode.com' | ||
| const button = ref<HTMLButtonElement>(null) | ||
| const button = ref<HTMLButtonElement | null>(null) |
|
Do we need to handle the case where the |
…ere elements may be `null`
Yes. Of course. |
ilyaliao
reviewed
Apr 27, 2025
ilyaliao
previously approved these changes
Apr 27, 2025
antfu
previously approved these changes
May 14, 2025
Type 'null' is not assignable to type 'HTMLElement
antfu
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e 'HTMLElement'`
Before submitting the PR, please make sure you do the following
fixes #123).Description
fix typescript error.
Additional context