use nextTick instead of setTimeout

vueuse · hunterwilhelm · Apr 3, 2025 · Apr 4, 2025 · Apr 7, 2025 · Apr 4, 2025
commit e8cd2b40d1ecb5556819f79b3c32ed424927dbb6
diff --git a/packages/core/useMagicKeys/index.ts b/packages/core/useMagicKeys/index.ts
@@ -1,6 +1,6 @@
 import type { ComputedRef, MaybeRefOrGetter } from 'vue'
 import { noop } from '@vueuse/shared'
-import { computed, reactive, shallowRef, toValue } from 'vue'
+import { computed, nextTick, reactive, shallowRef, toValue } from 'vue'
 import { defaultWindow } from '../_configurable'
 import { useEventListener } from '../useEventListener'
 import { DefaultMagicKeysAliasMap } from './aliasMap'
@@ -142,9 +142,9 @@ export function useMagicKeys(options: UseMagicKeysOptions<boolean> = {}): any {
    // Solution: Trigger "keyup" event manually when "keydown" event is fired without "keyup"
    if (key && e.getModifierState('Meta') && current.has(key)) {
      updateRefs(e, false)
-      setTimeout(() => {
+      nextTick(() => {
        updateRefs(e, true)
-      }, 0)
+      })
    }
    else {
      updateRefs(e, true)
-Original file line number
+Diff line change
@@ -1,6 +1,6 @@
     import type { ComputedRef, MaybeRefOrGetter } from 'vue'
     import { noop } from '@vueuse/shared'
-    import { computed, reactive, shallowRef, toValue } from 'vue'
+    import { computed, nextTick, reactive, shallowRef, toValue } from 'vue'
     import { defaultWindow } from '../_configurable'
     import { useEventListener } from '../useEventListener'
     import { DefaultMagicKeysAliasMap } from './aliasMap'
@@ -142,9 +142,9 @@ export function useMagicKeys(options: UseMagicKeysOptions<boolean> = {}): any {
         // Solution: Trigger "keyup" event manually when "keydown" event is fired without "keyup"
         if (key && e.getModifierState('Meta') && current.has(key)) {
             Copy link

  
      
    
  

  
      

  
    Collaborator


      

  

  
    
      

      
            OrbisK
  

      

      

      


        Apr 4, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      it this a meta key only problem? what about shift and ctrl?
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



  
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      



      

  Author


  

  
    
      

      
            hunterwilhelm
  

      

      

      


        Apr 4, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      @OrbisK Yes it's only a meta key problem. Shift and ctrl don't have any issues on Mac
More info:

https://stackoverflow.com/questions/25438608/javascript-keyup-isnt-called-when-command-and-another-is-pressed

https://blog.bitsrc.io/keyup-event-and-cmd-problem-88f4038c5ed2
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
            OrbisK reacted with thumbs up emoji
      
        
            
    All reactions
  


          
              
                👍
                  1 reaction
           updateRefs(e, false)
-          setTimeout(() => {
+          nextTick(() => {
             updateRefs(e, true)
-          }, 0)
+          })
         }
         else {
           updateRefs(e, true)
-          Expand Down