Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(useDropZone): Allow passing document as target #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix(useDropZone): Allow passing document as target #4681

merged 1 commit into from
Apr 1, 2025

Conversation

osbre
Copy link
Contributor

@osbre osbre commented Mar 28, 2025

If one wants to drop files on the entire page, they need to pass document as the target:

useDropZone(window.document, {
    onDrop: (files) => console.log('Dropped files:', files),
})

This PR fixes the TypeScript type to allow Document usage.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 28, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 28, 2025
@43081j 43081j added this pull request to the merge queue Apr 1, 2025
@43081j 43081j removed this pull request from the merge queue due to a manual request Apr 1, 2025
@43081j 43081j added this pull request to the merge queue Apr 1, 2025
Merged via the queue into vueuse:main with commit 21fa652 Apr 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrbisK OrbisK OrbisK approved these changes

@ilyaliao ilyaliao ilyaliao approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osbre @OrbisK @ilyaliao @43081j
Morty Proxy This is a proxified and sanitized view of the page, visit original site.