test(ci): add additional attw test for built packages #4648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrbisK
reviewed
Mar 5, 2025
package.json
Outdated
| @@ -29,6 +29,7 @@ | ||
| "test:firefox": "vitest --project=\"browser (firefox)\"", | ||
| "test:chromium": "vitest --project=\"browser (chromium)\"", | ||
| "test:unit": "vitest --project unit", | ||
| "test:types": "pnpm -r test:attw", |
There was a problem hiding this comment.
lets do test:attw here too, no?
There was a problem hiding this comment.
ohh, I forgot to rename it, good catch
There was a problem hiding this comment.
upps, I need to update also ci
There was a problem hiding this comment.
argg, we don't have cancellation
OrbisK
reviewed
Mar 5, 2025
OrbisK
previously approved these changes
Mar 5, 2025
ilyaliao
previously approved these changes
Mar 5, 2025
userquin
commented
Mar 5, 2025
packages/math/package.json
Outdated
| @@ -44,7 +44,9 @@ | ||
| ], | ||
| "scripts": { | ||
| "build": "rollup --config=rollup.config.ts --configPlugin=rollup-plugin-esbuild", | ||
| "prepack": "pnpm run build" | ||
| "prepack": "pnpm run build", | ||
| "test:attw": "npx --yes @arethetypeswrong/cli --pack .", |
There was a problem hiding this comment.
change this to use attw
There was a problem hiding this comment.
looks like I forgot to change this entry 😒
OrbisK
approved these changes
Mar 5, 2025
antfu
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).Description
This PR adds additionnal CI types test via arethetypeswrong cli (attw)
Additional context
It is also ready to switch the configuration to ESM-only PR (#4581) just renaming
test:attw-esm-onlytotest:attwand removing the originaltest:attwscript on each package.json file.