Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(onStartTyping): Incorrect accepted valid characters #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2025
Merged

fix(onStartTyping): Incorrect accepted valid characters #4616

merged 3 commits into from
Mar 3, 2025

Conversation

Bernard-Borg
Copy link
Contributor

@Bernard-Borg Bernard-Borg commented Feb 19, 2025 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Description

This PR fixes the characters which are accepted when using onStartTyping. Specifically, it adds back the ability for users to start typing with Numpad0 to focus on the connected element (#4614, related: #2932).

Additional context

Should more characters be accepted or are just the basic letters and numbers enough?

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 19, 2025
@OrbisK
Copy link
Collaborator

OrbisK commented Feb 20, 2025

Thank you for your PR. Can we get some tests for this? so we prevent this from happening again? 😄

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 20, 2025
@Bernard-Borg
Copy link
Contributor Author

Bernard-Borg commented Feb 20, 2025 •
edited
Loading

Thank you for your PR. Can we get some tests for this? so we prevent this from happening again? 😄

I have added a couple of test cases.
I have never actually used Vitest before, so I'm sure they could be better. Could you check them out?
Thanks

43081j
43081j requested changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add one more test 👀 a negative

e.g. if you type arrow keys or some such thing, we do not trigger the callback

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 2, 2025
@ilyaliao ilyaliao added this pull request to the merge queue Mar 3, 2025
Merged via the queue into vueuse:main with commit 58a3b70 Mar 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@43081j 43081j 43081j approved these changes

@OrbisK OrbisK OrbisK approved these changes

@ilyaliao ilyaliao ilyaliao approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bernard-Borg @OrbisK @43081j @ilyaliao
Morty Proxy This is a proxified and sanitized view of the page, visit original site.