Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(useScroll): handle negative scroll values #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix(useScroll): handle negative scroll values #4613

merged 2 commits into from
Mar 5, 2025

Conversation

ilyaliao
Copy link
Member

@ilyaliao ilyaliao commented Feb 19, 2025 •
edited by antfu
Loading

fix #4611, fix #4538

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

This PR fixed the issue where useScroll was not correctly reflecting the arrivedState.

Now when using useInfiniteScroll, you need to set it up like this:

direction: bottom:

No need to set any flex properties.

direction: top:

display: flex;
flex-direction: column-reverse;

direction: left:

display: flex;
flex-direction: row-reverse;

direction: right:

display: flex;

Additional context

We need to be careful not to damage other functions. #2577

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 19, 2025
@ilyaliao @eavlee
fix(useScroll): handle negative scroll values
fc37272 
Co-authored-by: eavlee <eavlee@users.noreply.github.com>
@ilyaliao ilyaliao force-pushed the fix/useScroll-direction branch from e3e6617 to fc37272 Compare February 19, 2025 12:11
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 19, 2025
@OrbisK
Copy link
Collaborator

OrbisK commented Feb 20, 2025

I think we should have a closer look here.

  1. we should add an example to the docs for how to use direction top
  2. we should evaluate if we can/should resprect:

Column-reverse might fix it but I don't want my implementation to be css dependent.

comment from @awais019.

@ilyaliao
Copy link
Member Author

  1. we should add an example to the docs for how to use direction top

Agree, maybe we can add it in this PR.

  1. we should evaluate if we can/should resprect:

Humm, I think a CSS solution would be simpler. At least we can more easily explain to users "how to use it."

@ilyaliao ilyaliao mentioned this pull request Feb 21, 2025
Closed
7 tasks
@11thandRagde
Copy link

Following, this issue is impacting users in my product. Thank you for working on a fix!

@Galllarate
Copy link

Galllarate commented Mar 4, 2025 •
edited
Loading

Hi, sorry, I don't know how this process works in open source, but how long can it take? I made an issue two weeks ago, and as I saw here, the fix has already been implemented but not merged.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 4, 2025
@antfu antfu added this pull request to the merge queue Mar 5, 2025
Merged via the queue into vueuse:main with commit 4b7ab55 Mar 5, 2025
8 checks passed
@Azurox
Copy link

Azurox commented May 16, 2025

Unsure if I'm doing something wrong but it seems that the value distance is not respected when using the top direction

Repro
https://codesandbox.io/p/devbox/staging-currying-zyqr7s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrbisK OrbisK OrbisK approved these changes

@EvgenyWas EvgenyWas EvgenyWas approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
7 participants
@ilyaliao @OrbisK @11thandRagde @Galllarate @Azurox @EvgenyWas @antfu
Morty Proxy This is a proxified and sanitized view of the page, visit original site.