Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

docs(useClipboardItems): fix demo by using text/plain mime type #4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

OrbisK
Copy link
Collaborator

@OrbisK OrbisK commented Jan 19, 2025

fixes #4461

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

For some reason text/html does not work for the demo. Used text/plain instead.

Additional context

Note

using text/html needs some additional work when reading the value: https://codesandbox.io/p/sandbox/restless-hill-t3zh34?file=%2Fsrc%2Findex.mjs%3A34%2C26
we might need a followup here

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jan 19, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 19, 2025
@OrbisK OrbisK changed the title docs(useClipboardItems): use text/plain mimetype for demo docs(useClipboardItems): fix demo by using text/plain mime type Jan 19, 2025
@babu-ch
Copy link
Contributor

babu-ch commented Jan 20, 2025

You might want to change the mimetype in Usage to text/plain as well. 😄
https://vueuse.org/core/useClipboardItems/#usage

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2025
@antfu antfu added this pull request to the merge queue Jan 22, 2025
Merged via the queue into vueuse:main with commit 0ebefbe Jan 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG | useClipboardItems | "ReferenceError: ClipboardItem is not defined"
4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.