feat(useClipboard): should fall back to legacy clipboard when read/write fails #4512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
antfu
approved these changes
Jan 22, 2025
This was referenced Jan 23, 2025
Vitalis11
reviewed
Feb 19, 2025
Comment on lines
+76
to
+83
| try { | ||
| navigator!.clipboard.readText().then((value) => { | ||
| text.value = value | ||
| }) | ||
| } | ||
| catch { | ||
| useLegacy = true | ||
| } |
There was a problem hiding this comment.
Unhandled rejection! Either use Promise.catch(callback) or await instead of Promise.then()
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3813
Before submitting the PR, please make sure you do the following
fixes #123).Description
This PR ensures that
useClipboardfalls back to legacy if the read or write fails.Additional context
Tests are not fully developed. Waiting for #1259