Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat(useInputSelection,useInputCaretPosition): add useInputSelection and useInputCaretPosition #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
Loading
from

Conversation

OrbisK
Copy link
Collaborator

@OrbisK OrbisK commented Jan 16, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

closes #3834

this pr add two new composables.

Despite being classified as experimental, the selectionchange API should be very well supported. Chrome as well as Firefox and Safari trigger the event. There are minimal differences in the initial values (https://issues.chromium.org/issues/389368412), which is why I have also dispensed with an autofocus option for the time being.

This should not increase the maintenance effort.

Additional context

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request new function labels Jan 16, 2025
Comment on lines +24 to +25
onTestFailed(() => screen.unmount())
onTestFinished(() => screen.unmount())
Copy link
Collaborator Author

@OrbisK OrbisK Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are sometimes flaky if i dont do this. not sure why.

I think if a test fails the page is not unmounted, leaving the next tests with some unexpected initial state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new function size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

New: useCaretPosition
1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.