Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

test(watchDebounced): add tests to solve debounce max wait issue #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

OrbisK
Copy link
Collaborator

@OrbisK OrbisK commented Jan 8, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

this pr adds minimal reproduction of #3665. Added this test with it.todo. Not sure how to fix it yet. Looks like the callback is being called at the right time, but with old values.

Additional context

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 8, 2025
antfu
antfu previously approved these changes Jan 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 10, 2025
@antfu antfu self-requested a review January 10, 2025 07:15
@antfu
Copy link
Member

antfu commented Jan 10, 2025

We could remove the .todo and let it fail for such PR, so we know when the implementation get fixed it would pass

@antfu antfu added test suites and removed lgtm This PR has been approved by a maintainer labels Jan 10, 2025
@OrbisK
Copy link
Collaborator Author

OrbisK commented Jan 10, 2025

We could remove the .todo and let it fail for such PR, so we know when the implementation get fixed it would pass

I could do .fails so the pipeline is still green. and we would know when its fixed. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files. test suites
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.