add vue 2.7 compatibility to Head component #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Ideally, I'd like to avoid using I am open to adding it, but In this PR in particular it shouldn't be needed, as Vue 2.7 should have a |
|
Fair enough, I'll get that updated |
|
Without vue-demi the scope for this is pretty minimal so going to merge! Will see what I can do about the other PR. |
harlan-zw
added a commit
that referenced
this pull request
Nov 12, 2022
* refactor!: v1 initial, CSR performance, awaitable hooks (#126) * performance: rewrite reactivity for SSR / CSR * chore: rolleback artifacts * chore: progress commit * fix: use ./src import * refactor!: simplify utils for smaller pkg (#127) * performance: rewrite reactivity for SSR / CSR * chore: rolleback artifacts * chore: progress commit * fix: use ./src import * refactor: simplify util code for smaller payload * refactor!: continued (#128) * performance: rewrite reactivity for SSR / CSR * chore: rolleback artifacts * chore: progress commit * fix: use ./src import * refactor: simplify util code for smaller payload * wip: part two of refactor * chore: fix tests * chore: run github ci on v1 * chore: run github ci on v1 * chore: bump version * Release v1.0.0-rc.0 * Release v1.0.0-rc.1 * fix: ensure empty attrs reset attrs (#130) * fix: ensure empty attr is set * fix: test valid tags * fix(ci): release on rc * Release v1.0.0-rc.2 * fix(ci): remove broken --pre * Release v1.0.0-rc.3 * fix(ci): use --pre * fix: use simpler API for tags (#131) * feat: improved hook api (#132) * chore: prefer runtime prop for id & position (#134) * chore: prefer runtime prop for id & position * fix: type errors * fix: add `headTags` for backwards compatibility (#133) * Release v1.0.0-rc.4 * fix: add legacy `addHeadObjs` (#135) * refactor!: useHeadRaw -> useHeadSafe (#136) * refactor!: useHeadRaw -> useHeadSafe * feat: tree-shake encoding * chore: useHeadSafe types * Release v1.0.0-rc.5 * fix(types): export `MaybeComputedRef` * chore: add missing `type` * Release v1.0.0-rc.6 * chore(pkg): bump deps * fix(titleTemplate): allow titleTemplate to resolve the title (#137) * fix(titleTemplate): allow titleTemplate to resolve the title * chore: add happy case * chore: fix type issues * chore: maybe fix type issue * chore: maybe fix type issue * chore: maybe fix type issue * chore: maybe fix type issue * Release v1.0.0-rc.7 * chore: bump deps * chore: test issue #138 * chore: linting * chore(pkg): bump deps * Release v1.0.0-rc.8 * fix: ensure tags props are immutable (#139) * Release v1.0.0-rc.9 * chore(pkg): bump deps * Release v1.0.0-rc.10 * fix: ensure single pass of `htmlAttr` sanitization, fixes #142 (#143) * fix: ensure csr elements are created equally (#145) * fix: ensure csr elements are created equally * fix: remove sanitising * chore: fix doc * chore(pkg): bump deps * Release v1.0.0-rc.11 * fix: vue 2.7 globalProperties, fixes #141 * chore(pkg): bump zhead * Release v1.0.0-rc.12 * add vue 2.7 compatibility to Head component (#147) * add vue 2.7 compatibility to Head component * remove vue-demi in favor of checking version from vue itself * chore(pkg): bump deps * fix: dedupe `htmlAttrs` and `bodyAttrs` for csr (#149) * Release v1.0.0-rc.13 * fix: Vue 2.7 compatibility (#150) * add separate vue2 plugin for 2.7 compatibility * Vue 2.7 install readme * fix: handle style / class attrs * chore: add link back to pinia * chore: vue2 example Co-authored-by: Val Trubachev <val.trubachev@zoro.com> * chore(pkg): ignore eslint in vue2 example * Release v1.0.0-rc.14 * feat: migrate core to unhead (#157) * feat: migrate core to unhead * chore: fix SSR test with timeouts * chore: readme link fix * chore(pkg): bump deps * chore(ci): switch to next channel * chore: document install * Release v1.0.0-next.1 * chore: improve doc * chore: bump unhead, update tests and examples * Release v1.0.0-next.2 * chore: bump unhead * chore: expose `VueHeadMixin` * Release v1.0.0-next.3 Co-authored-by: Valera Trubachev <vetruvet@gmail.com> Co-authored-by: Val Trubachev <val.trubachev@zoro.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146 .
Adds
vue-demias a dependency, but it was already (indirectly) required by@vueuse/sharedso should not affect package size.Open questions/concerns (perhaps to @harlan-zw ?):
@vueuse/sharedspecifies*forvue-demi. I'm not sure if you want that or to specify an actual version like^0.13.11.@ts-expect-error