Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Updated typings to include default export #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2018
Merged

Updated typings to include default export #90

merged 1 commit into from
Jul 26, 2018

Conversation

keego
Copy link
Contributor

@keego keego commented Jul 24, 2018

Closes #89

This modifies the typings so that package 'vue-rx':

  1. now exports VueRx by default
  2. no longer exports install, which wasn't actually being exported anyway

VueRx should now be able to be imported as mentioned in the npm section of the README:

import Vue from 'vue'
import VueRx from 'vue-rx'

Vue.use(VueRx)

@keego
Copy link
Contributor Author

keego commented Jul 26, 2018

@yyx990803 should be good to go. Can I get a review?

@yyx990803 yyx990803 merged commit 4e640ed into vuejs:master Jul 26, 2018
@yyx990803
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keego @yyx990803
Morty Proxy This is a proxified and sanitized view of the page, visit original site.