Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Wiki Search Example will not cancel #101

Copy link
Copy link
Closed
@deanrad

Description

@deanrad
Issue body actions

Hi - I'm very curious in using this project. But this looks like a bug:

Given: Most searches should be canceled when a new search term is done, and that's what I take is the intention of using switchMap.
When: A search is performed
Expected: The old search is canceled.
Actual: Because of the use of jQuery and Promises, the Observable returned from fetchTerm will not be canceled when the search term changes.

I don't have screen shots yet, but based on the code, that's what I believe the behavior will be.

If the rxjs ajax operators were used, cancelability would be built in. And it's not a good example to use jQuery just for something that rxjs already has.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.