Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

gzzhanghao
Copy link
Contributor

@gzzhanghao gzzhanghao commented Mar 1, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

End location for incomplete tags are missing, which makes error message looks weird:

  tag <incomplete-tag> has no matching end tag.

  2  |  <div>
  3  |    <div>
  4  |      <incomplete-tag>
     |      ^^^^^^^^^^^^^^^^
  5  |    </div>
     |  ^^^^^^^^
  6  |  </div>
     |  ^^^^^^

Expected:

  tag <incomplete-tag> has no matching end tag.

  2  |  <div>
  3  |    <div>
  4  |      <incomplete-tag>
     |      ^^^^^^^^^^^^^^^^
  5  |    </div>
  6  |  </div>

@yyx990803 yyx990803 merged commit cbad54a into vuejs:dev Mar 1, 2019
@gzzhanghao gzzhanghao deleted the incomplete-element branch March 4, 2019 03:30
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.