-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Further improve Vue type declarations for canonical usage #6391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
5b5a88f
refactor TypeScript typings to use ES style exports
yyx990803 385a744
Allow functions in 'methods' & 'computed' to view themselves, as well…
DanielRosenwasser 8cd5b9c
Got 'new Vue(...)', 'Vue.extend(...)', and 'Vue.component(...)' working.
DanielRosenwasser 540a38f
Made it so that any 'data' function can only access 'props' and base …
DanielRosenwasser f34f4f6
Improved defaults, fixed overloads and types for functional component…
DanielRosenwasser b1f40ce
Condensed declaration of 'watch'.
DanielRosenwasser 355ff75
Added two tests for 'extend'.
DanielRosenwasser bc54007
.\types\options.d.ts
DanielRosenwasser e7ea5bb
Updated tests, tighted strictness.
DanielRosenwasser ebde0b1
Merge remote-tracking branch 'upstream/dev' into accurateVueTypes
DanielRosenwasser d78d14b
Made the Vue instance non-generic, made readonly, augmented tests.
DanielRosenwasser fc83771
Make it possible to extend Vue without type arguments.
DanielRosenwasser a50c838
Removed 'ThisTypedComponentOptions'.
DanielRosenwasser 3c86b10
Merge remote-tracking branch 'upstream/dev' into accurateVueTypes
DanielRosenwasser 33a106c
Upgraded dependency on TypeScript.
DanielRosenwasser 0f586db
Added test by @ktsn.
DanielRosenwasser 1092efe
Removed unnecessary mixin constructors, made 'VueConstructor' generic.
DanielRosenwasser ebd8c0b
Merge remote-tracking branch 'upstream/dev' into accurateVueTypes
DanielRosenwasser c628103
[release] weex-vue-framework@2.4.2-weex.1 (#6196)
Hanks10100 e4a8545
Merge remote-tracking branch 'upstream/dev' into accurateVueTypes
DanielRosenwasser 3cac5c7
fix-Firefox (#6359)
HiWangyeah d55bc63
feat(typing): compatible interface declaration
HerringtonDarkholme 07eb21c
improve typing and tests
HerringtonDarkholme e7777d7
Merge branch 'new-type' of github.com:HerringtonDarkholme/vue into ne…
HerringtonDarkholme 21d62a1
fix(typing): change default computed typing
HerringtonDarkholme 0958bda
feat(typing): add more specific prop typing
HerringtonDarkholme 6c76c45
feat(typing): refine props
HerringtonDarkholme 5335788
fix(typing): fix some typing errors
HerringtonDarkholme 8a1aab2
fix(typing): add async component back
HerringtonDarkholme 042e1c3
test(typing): add small granular test
HerringtonDarkholme 76de5dc
feat(typing): add ArrayProp back
HerringtonDarkholme 070460b
feat(typing): add array types back
HerringtonDarkholme 718dd7d
feat(typing): add array prop to extend/component
HerringtonDarkholme 89f958b
feat(typing): add string prop test
HerringtonDarkholme da53a0a
fix(typing): add more compatibility test
HerringtonDarkholme e034641
fix(typing): address code review feedback
HerringtonDarkholme c9f0939
fix(typing): add cyclic test case
HerringtonDarkholme 754d0df
feat(typing): add union type test
HerringtonDarkholme b784785
feat(typing): use call signatures
HerringtonDarkholme d5fbd81
fix(typing): add tests for regexp and array
HerringtonDarkholme 37c5883
feat(typing): label props as readonly
HerringtonDarkholme 9e6931a
fix(typing): this in beforeCreate is plain Vue
HerringtonDarkholme d9accb0
fix(typing): fix beforeCreate test
HerringtonDarkholme b90386a
fix(typing): use extended typing
HerringtonDarkholme 67eab9c
chore: update backers
yyx990803 97a401e
Merge branch 'dev' of github.com:vuejs/vue into new-type
HerringtonDarkholme 8df15b7
Merge branch 'dev' of github.com:vuejs/vue into new-type
HerringtonDarkholme 1ac0b7a
Merge branch 'new-type' of github.com:HerringtonDarkholme/vue into ne…
HerringtonDarkholme 4649739
Simplify 'CreateElement', remove potential error in 'AsyncComponent' …
DanielRosenwasser c953990
Simplify down to two overloads.
DanielRosenwasser 8901752
Merge pull request #1 from DanielRosenwasser/simplifyCreateElement
HerringtonDarkholme a7f84d9
Merge branch 'dev' of github.com:vuejs/vue into new-type
HerringtonDarkholme 5fa1ab9
Merge branch 'new-type' of github.com:HerringtonDarkholme/vue into ne…
HerringtonDarkholme a595239
fix(typing): fix functional component typing
HerringtonDarkholme 00aa9d3
Merge branch 'dev' of github.com:vuejs/vue into new-type
HerringtonDarkholme 6091248
Merge branch 'dev' of github.com:vuejs/vue into new-type
HerringtonDarkholme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(typing): add array types back
- Loading branch information
commit 070460bb7fb1f1576690fc1c7b9e856276cf24b3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we let
value
type toT
since we can infer prop type now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of validator is testing
any
thing if it is of type T, soany
is more appropriate here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But at least its type is specified by
type
option, isn't it?The other types than
type
is not come here on runtime.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I forget there is builtin check before validator!