-
Notifications
You must be signed in to change notification settings - Fork 542
Merge meta
fields from parent to child
#144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I like this one. It's going to make meta accessing much easier 🙌 One question. Why is {
path: '/parent',
meta: { nested: { requiresAuth: true, isChild: false } },
children: [
{ path: 'child', meta: { isChild: true }}
]
}
// becomes
{ requiresAuth: true, isChild: true } And {
path: '/parent',
meta: { nested: { a: true } },
children: [
{ path: 'child', meta: { nested: { b: true }}}
]
}
// becomes
{
nested: {
b: true
}
} Wouldn't the first example become as below? {
nested: {
requiresAuth: true,
isChild: true
},
isChild: false
} Or, is |
Thanks @kiaking That was indeed a mistake. I fixed it |
This RFC is now in final comments stage. An RFC in final comments stage means that: The core team has reviewed the feedback and reached consensus about the general direction of the RFC and believe that this RFC is a worthwhile addition to the framework. |
The rendered link gives 404 |
I may jump into that one a bit late but in my case merging meta doesn't sound that great. '/' // title = App name
'settings' // title = Setting - App name
'users' // title = Users - Settings - App name As merging the |
@ludohenin Since you need all values from |
@posva ah OK, perfect then ;-) |
Rendered