Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(no-unused-emit-declarations): detect emits in templates #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 27, 2023
Merged

fix(no-unused-emit-declarations): detect emits in templates #2340

merged 3 commits into from
Dec 27, 2023

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Dec 2, 2023

try to fix #2337

FloEdelmann
FloEdelmann approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I have just two minor nits, otherwise this looks good to me 🙂

tests/lib/rules/no-unused-emit-declarations.js Outdated Show resolved Hide resolved
tests/lib/rules/no-unused-emit-declarations.js Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann requested a review from ota-meshi December 4, 2023 14:45
FloEdelmann
FloEdelmann reviewed Dec 13, 2023
View reviewed changes
lib/rules/no-unused-emit-declarations.js Outdated Show resolved Hide resolved
lib/rules/no-unused-emit-declarations.js Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann mentioned this pull request Dec 13, 2023
Merged
ota-meshi
ota-meshi approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! Sorry for the late review.
I didn't realize that usage was not supported 😅

@ota-meshi ota-meshi merged commit cc0b0f0 into vuejs:master Dec 27, 2023
@ntnyq ntnyq mentioned this pull request Jan 31, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/no-unused-emit-declarations doesn't detect emits in templates
3 participants
@waynzh @FloEdelmann @ota-meshi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.