Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Allow custom toggles in vue/require-toggle-inside-transition  #2535

Copy link
Copy link
Closed
@cjpearson

Description

@cjpearson
Issue body actions

What rule do you want to change?

vue/require-toggle-inside-transition

Does this change cause the rule to produce more or fewer warnings?

If option is configured, fewer warnings.

How will the change be implemented? (New option, new default behavior, etc.)?

I would add a new option to the rule which allows adding additional custom "toggle" directives which will satisfy this check in addition to v-show or v-if.

Please provide some example code that this change will affect:

<transition>
  <dialog v-dialog="visible">...</dialog>
</transition>

What does the rule currently do for this code?

It flags it as an error, because there is no v-show or v-if on the <dialog>

What will the rule do after it's changed?

If the rule is configured to include v-dialog as a toggle directive, it will no longer flag this case as an error.

Additional context

In the example above, v-dialog is a custom directive which shows/hides the element using close() and showModal(). Transitions are also applied in the directive.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.