Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: add eslint.config.* to tsconfig.node.json and fix other eslint issues #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 20, 2025
Merged

fix: add eslint.config.* to tsconfig.node.json and fix other eslint issues #669

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8b8bc76
fix: add eslint.config.* to tsconfig.node.json
haoqunjiang Jan 20, 2025
9e11ae8
chore: add eslint flag to snapshot scripts
haoqunjiang Jan 20, 2025
ddf37a5
fix: fix cypress-ct eslint config
haoqunjiang Jan 20, 2025
0929795
fix(ts-cypress-eslint): ignore ts error caused by lack of declaration…
haoqunjiang Jan 20, 2025
b9aa4f2
fix: add one more comment to allow @ts-ignore
haoqunjiang Jan 20, 2025
03c24ed
ci: skip nightwatch + eslint tests
haoqunjiang Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add eslint flag to snapshot scripts 
Previously we don't generate all possible combinations of flags for
eslint, therefore missing this bug in typescript-eslint projects.

I wanted to add snapshots for prettier feature too, but it currently
is a bit messy, I need to refactor that part first.
  • Loading branch information
@haoqunjiang
haoqunjiang committed Jan 20, 2025
commit 9e11ae89a651cd46d243d62712bdb286533e31a2
3 changes: 2 additions & 1 deletion 3 scripts/snapshot.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const featureFlags = [
'cypress',
'playwright',
'nightwatch',
'eslint',
]
const featureFlagsDenylist = [
['cypress', 'playwright'],
Expand Down Expand Up @@ -55,7 +56,7 @@ function fullCombination(arr) {
}

let flagCombinations = fullCombination(featureFlags)
flagCombinations.push(['default'], ['bare', 'default'], ['eslint'], ['eslint-with-prettier'])
flagCombinations.push(['default'], ['bare', 'default'], ['eslint-with-prettier'])

// `--with-tests` are equivalent of `--vitest --cypress`
// Previously it means `--cypress` without `--vitest`.
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.