chore: improve code

vuejs · edison1105 · Sep 2, 2025 · May 2, 2023 · May 2, 2023 · May 2, 2023
commit 3dc4e4416db3ca404f6ee0c1f2b8a0afbd23433f
diff --git a/packages/runtime-core/src/h.ts b/packages/runtime-core/src/h.ts
@@ -179,9 +179,8 @@ export function h<P>(
 export function h(type: any, propsOrChildren?: any, children?: any): VNode {
  // #6913 disable tracking block in h function
  const doCreateVNode = (type: any, props?: any, children?: any) => {
-    let vnode: VNode
    setBlockTracking(-1)
-    vnode = createVNode(type, props, children)
+    const vnode = createVNode(type, props, children)
    setBlockTracking(1)
    return vnode
  }
-Original file line number
+Diff line change
@@ -179,9 +179,8 @@ export function h<P>(
     export function h(type: any, propsOrChildren?: any, children?: any): VNode {
       // #6913 disable tracking block in h function
       const doCreateVNode = (type: any, props?: any, children?: any) => {
             Copy link

  
      
    
  

  
      



      

  

  
    
      

      
            spaceemotion
  

      

      

      


        Sep 2, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Just stumbled upon this as I was reading the changelog. Is there a reason why every call to h will now (afaik) create an inline version of doCreateVNode? Can't this be created outside of the scope of calling h()?
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



    
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
  Member


      

  Author


  

  
    
      

      
            edison1105
  

      

      

      


        Sep 3, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      You are right,  I made some simplifications to the h function and removed the doCreateVNode function. See #13841
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
            spaceemotion reacted with thumbs up emoji
      
        
            
    All reactions
  


          
              
                👍
                  1 reaction
-        let vnode: VNode
         setBlockTracking(-1)
-        vnode = createVNode(type, props, children)
+        const vnode = createVNode(type, props, children)
         setBlockTracking(1)
         return vnode
       }
-          Expand Down