Fix vEOS port alignment #256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all vEOS specific code to the specific launcy.py file.
Workaround that the mgmt interface needs to be first on the bus. We still need to keep the correct port numbering to make sure xcon works correctly.
This reverts commit f52a433.
Contributor
Author
|
@emjemj requested that the topomachine change would be done in a separate PR so I have reverted that commit in this PR. |
monrad
added a commit
to monrad/vrnetlab
that referenced
this pull request
Nov 21, 2021
This change needs the change in vrnetlab#256 to not be off by one in every interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure the first PCI id is used for the mangement interface all ports were bumped by one so vr-xcon would be off by one when.
Special handling for vEOS is moved from the common vrnetlab.py kode into the vEOS launch.py file.
My "naive" fix is just to decrement the i variable after it has been used for the PCI bus calculations so the port numbers line up with the correct ports.
This pull request also includes vEOS support for the topomachine.