Support key encodings#2
Open
Frando wants to merge 2 commits intovoltraco:mastervoltraco/level-live:masterfrom
Open
Support key encodings#2Frando wants to merge 2 commits intovoltraco:mastervoltraco/level-live:masterfrom
Frando wants to merge 2 commits intovoltraco:mastervoltraco/level-live:masterfrom
Conversation
Author
|
Oh, this branch also includes #1 . This PR is only concerned with the second commit. If #1 gets committed first this should merge. Otherwise I'll update here with only that commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when using different key encodings, the key encodings are not applied to messages emitted when in live mode (after the original read stream finishes).
This PR makes the key uniform in read and live mode by using the level-codec module (which levelup etc also use).