Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

eric-haibin-lin
Copy link
Collaborator

What does this PR do?

Previously, the sharding manager would throw AttributeError that self.timing is not defined.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

Added to ppo fsdp test suite.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an AttributeError in the sharding manager and includes a new single-GPU test for the HF rollout. The PR also includes cleanups, removing the default_hdfs_dir parameter from various scripts and documentation. A more robust approach to initializing self.timing in BaseShardingManager is recommended.

verl/workers/sharding_manager/base.py Show resolved Hide resolved
@eric-haibin-lin eric-haibin-lin enabled auto-merge (squash) July 5, 2025 05:50
@eric-haibin-lin eric-haibin-lin merged commit cbeb3f4 into volcengine:main Jul 5, 2025
47 checks passed
@eric-haibin-lin eric-haibin-lin deleted the hlin/hf branch July 5, 2025 14:51
SuperCB pushed a commit to SuperCB/verl that referenced this pull request Jul 7, 2025
yellowbee686 pushed a commit to yellowbee686/verl that referenced this pull request Jul 7, 2025
oseyosey pushed a commit to oseyosey/verl that referenced this pull request Jul 28, 2025
Juniper1021 pushed a commit to Juniper1021/verl that referenced this pull request Aug 7, 2025
whatadayG pushed a commit to whatadayG/verl that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.