Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[sglang] feat: Add multi-interaction registry support and testing #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 27, 2025
Merged

[sglang] feat: Add multi-interaction registry support and testing #2184

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e0699ec
Add multi-interaction registry support and testing
SwordFaith Jun 24, 2025
f6f12e1
Update related doc
SwordFaith Jun 24, 2025
50e2f87
Fix unit-test bug
SwordFaith Jun 24, 2025
178024e
Fix multi interaction test world_size issue
SwordFaith Jun 25, 2025
6b3f1fa
FIx world_size issue in mock
SwordFaith Jun 25, 2025
69e1dcb
FIx dist env mock issue
SwordFaith Jun 25, 2025
e16c29e
Fix dist env uninit
SwordFaith Jun 25, 2025
ed24f1d
Try fix ci
SwordFaith Jun 25, 2025
460b4b5
Try fix validation error
SwordFaith Jun 25, 2025
612d1f0
Fix ci bug
SwordFaith Jun 25, 2025
0ae0572
Fix mp isinstance issue
SwordFaith Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ci bug
  • Loading branch information
@SwordFaith
SwordFaith committed Jun 25, 2025
commit 612d1f0f5ef2801f8eee930681c0f6ea48dd85fa
23 changes: 9 additions & 14 deletions 23 tests/workers/rollout/test_sglang_multi_interaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,14 +213,13 @@ def test_fallback_to_default_interaction(self):

try:
with patch.object(SGLangRollout, "_init_distributed_env", return_value=None), patch.object(SGLangRollout, "_init_inference_engine", return_value=None), patch.object(SGLangRollout, "_init_sampling_params", return_value=None):
mock_tokenizer = MagicMock()
mock_tokenizer.pad_token_id = 0
mock_tokenizer.eos_token_id = 2
tokenizer = AutoTokenizer.from_pretrained("Qwen/Qwen2.5-0.5B", padding_side="left")
tokenizer.pad_token = tokenizer.eos_token

mock_model_config = MagicMock()
mock_model_config.max_position_embeddings = 2048

rollout = SGLangRollout(actor_module="mock_model", config=config, processing_class=mock_tokenizer, model_hf_config=mock_model_config, port=None, trust_remote_code=False, device_mesh=None)
rollout = SGLangRollout(actor_module="mock_model", config=config, processing_class=tokenizer, model_hf_config=mock_model_config, port=None, trust_remote_code=False, device_mesh=None)

# Test that default interaction name works
interaction_kwargs_without_name = {"test_param": "value"}
Expand All @@ -238,14 +237,13 @@ def test_error_on_missing_interaction(self):

try:
with patch.object(SGLangRollout, "_init_distributed_env", return_value=None), patch.object(SGLangRollout, "_init_inference_engine", return_value=None), patch.object(SGLangRollout, "_init_sampling_params", return_value=None):
mock_tokenizer = MagicMock()
mock_tokenizer.pad_token_id = 0
mock_tokenizer.eos_token_id = 2
tokenizer = AutoTokenizer.from_pretrained("Qwen/Qwen2.5-0.5B", padding_side="left")
tokenizer.pad_token = tokenizer.eos_token

mock_model_config = MagicMock()
mock_model_config.max_position_embeddings = 2048

rollout = SGLangRollout(actor_module="mock_model", config=config, processing_class=mock_tokenizer, model_hf_config=mock_model_config, port=None, trust_remote_code=False, device_mesh=None)
rollout = SGLangRollout(actor_module="mock_model", config=config, processing_class=tokenizer, model_hf_config=mock_model_config, port=None, trust_remote_code=False, device_mesh=None)

# Test error when requesting non-existent interaction
non_existent_name = "non_existent_interaction"
Expand Down Expand Up @@ -283,16 +281,13 @@ def test_backward_compatibility_no_interaction_config(self):
)

with patch.object(SGLangRollout, "_init_distributed_env", return_value=None), patch.object(SGLangRollout, "_init_inference_engine", return_value=None), patch.object(SGLangRollout, "_init_sampling_params", return_value=None):
mock_tokenizer = MagicMock()
mock_tokenizer.pad_token_id = 0
mock_tokenizer.eos_token_id = 2
tokenizer = AutoTokenizer.from_pretrained("Qwen/Qwen2.5-0.5B", padding_side="left")
tokenizer.pad_token = tokenizer.eos_token

mock_model_config = MagicMock()
mock_model_config.max_position_embeddings = 2048

rollout = SGLangRollout(actor_module="mock_model", config=config, processing_class=mock_tokenizer, model_hf_config=mock_model_config, port=None, trust_remote_code=False, device_mesh=None)
rollout = SGLangRollout(actor_module="mock_model", config=config, processing_class=tokenizer, model_hf_config=mock_model_config, port=None, trust_remote_code=False, device_mesh=None)

# Check that no interactions were initialized
assert len(rollout.interaction_map) == 0

# Should work without errors (backward compatibility)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.