Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Easy] Get rid of unnecessary paraenthesis in kv_cache_manager #26842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

[Easy] Get rid of unnecessary paraenthesis in kv_cache_manager #26842

merged 1 commit into from
Oct 15, 2025
+1 −1

Conversation

Jialin
Copy link
Contributor

@Jialin Jialin commented Oct 14, 2025 •
edited by github-actions bot
Loading

Purpose

Address leftover styling comments in #24964

Test Plan

N/A

Test Result

N/A

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@Jialin
[Easy] Get rid of unnecessary paraenthesis in kv_cache_manager
9e939ee 
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unnecessary parentheses from a return statement in kv_cache_manager.py. This is a minor but good stylistic improvement that aligns with Python best practices. The change is correct and I have no further feedback.

@Jialin Jialin mentioned this pull request Oct 14, 2025
Merged
5 tasks
@mergify mergify bot added the v1 label Oct 14, 2025
@yeqcharlotte yeqcharlotte enabled auto-merge (squash) October 15, 2025 05:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 15, 2025
@yeqcharlotte yeqcharlotte merged commit 7f83b4e into vllm-project:main Oct 15, 2025
49 checks passed
bbartels pushed a commit to bbartels/vllm that referenced this pull request Oct 16, 2025
@Jialin @bbartels
[Easy] Get rid of unnecessary paraenthesis in kv_cache_manager (vllm-…
c59eba0 
…project#26842)

Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Signed-off-by: bbartels <benjamin@bartels.dev>
mandy-li pushed a commit to mandy-li/vllm that referenced this pull request Oct 16, 2025
@Jialin @mandy-li
[Easy] Get rid of unnecessary paraenthesis in kv_cache_manager (vllm-…
eb8be1a 
…project#26842)

Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request Oct 16, 2025
@Jialin @albertoperdomo2
[Easy] Get rid of unnecessary paraenthesis in kv_cache_manager (vllm-…
27fa6ec 
…project#26842)

Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request Oct 16, 2025
@Jialin @albertoperdomo2
[Easy] Get rid of unnecessary paraenthesis in kv_cache_manager (vllm-…
9cdfd25 
…project#26842)

Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yeqcharlotte yeqcharlotte yeqcharlotte approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@heheda12345 heheda12345 Awaiting requested review from heheda12345 heheda12345 is a code owner

@ApostaC ApostaC Awaiting requested review from ApostaC ApostaC is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jialin @yeqcharlotte
Morty Proxy This is a proxified and sanitized view of the page, visit original site.